D10995: Fix some compile warnings

Elvis Angelaccio noreply at phabricator.kde.org
Sat Mar 3 22:10:25 GMT 2018


elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphinmainwindow.cpp:414
>                  m_tabWidget->closeTab();
> +                // fall through
>              default:

Don't we need a  `break` here?

> kitemlistcontroller.cpp:438-439
>          }
> -        // Fall through to the default case and add the Space to the current search string.
> -
> +        // fall through
> +        // to the default case and add the Space to the current search string.
>      default:

Why this change?

REPOSITORY
  R318 Dolphin

BRANCH
  fix-warnings

REVISION DETAIL
  https://phabricator.kde.org/D10995

To: rominf, #dolphin, markg
Cc: elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/3b0c1ad5/attachment.htm>


More information about the kfm-devel mailing list