D10990: Add "Open symlink destination folder" into symlink's context menu

[Nathaniel Graham]

ngraham added a comment.


  In D10990#217481 <https://phabricator.kde.org/D10990#217481>, @rominf wrote:
  
  > In D10990#217450 <https://phabricator.kde.org/D10990#217450>, @ngraham wrote:
  >
  > > @rominf how about "Show Original" instead of "Open symlink destination folder". Let's try to use more natural, less nerdy terminology here.
  >
  >
  > Fixed.
  >
  > > Also, can you conditionally add this to the file menu, too? Let's try not to have any functionality that you can only access via a context menu.
  >
  > Will fix it.
  >
  > > Also, how about always highlighting the original in Dolphin rather than opening it if it's a folder? You could use `KIO:highlightInFileManager()` for that.
  >
  > `KIO:highlightInFileManager()` opens destination in new window. I don't like it. Actually, I would prefer "Show Original in new tab".
  
  
  And down the rabbit hole we go...
  
  How to open new folders (same window/new window/new tab) is itself another matter, and I would be in favor of making that configurable, which would also solve https://bugs.kde.org/show_bug.cgi?id=183429. That's another patch, though.
  
  In the meantime, let's use the `KIO:highlightInFileManager()` behavior and open in a new window. Windows are easier to manage for most normal users than multiple tabs within windows. Then later, once we have a GUI control for how to handle new window requests, we'll be able to expose functionality to make them open in new tabs (or even replace the contents of the current window) per user preference.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10990

To: rominf, #dolphin
Cc: ngraham, elvisangelaccio, markg, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/543d47ba/attachment.htm>