D10959: Add action for focusing Terminal Panel

Roman Inflianskas noreply at phabricator.kde.org
Sat Mar 3 13:59:11 GMT 2018


rominf marked an inline comment as done.
rominf added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in terminalpanel.h:58-64
> `QWidget::setFocus()`, `QWidget::hasFocus()` and `QWidget::setFocus(Qt::FocusReason reason)` are not virtual, I'm not sure this is a good idea.

I've tried to use `focusProxy` but it didn't work (maybe it's just me). What do you propose?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10959

To: rominf, #dolphin, elvisangelaccio
Cc: elvisangelaccio, rkflx, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/a4a30ad7/attachment.htm>


More information about the kfm-devel mailing list