D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

Henrik Fehlauer noreply at phabricator.kde.org
Sat Mar 3 07:38:40 GMT 2018


rkflx added a comment.


  In D10960#217237 <https://phabricator.kde.org/D10960#217237>, @rominf wrote:
  
  > - Fix crash on Dolphin closing
  
  
  👍

INLINE COMMENTS

> terminalpanel.cpp:106-109
> +    if (m_terminal)
> +        return m_terminal->foregroundProcessName();
> +    else
> +        return QString();

Add `{}` like it's done in most places in the codebase.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham, markg
Cc: markg, ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/daf6f9a9/attachment.htm>


More information about the kfm-devel mailing list