D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Roman Inflianskas]

rominf marked 5 inline comments as done.
rominf added inline comments.

INLINE COMMENTS

> ngraham wrote in dolphinmainwindow.cpp:432
> The Show Terminal Panel button should probably only be displayed if the Terminal panel is hidden. Otherwise it seems odd that it's there, and when you click on it, nothing different appears to happen compared to just hitting the cancel button.

> Otherwise it seems odd that it's there, and when you click on it, nothing different appears to happen compared to just hitting the cancel button.

Terminal panel gets focus. I think it's reasonable to keep the button. Your opinion?

> markg wrote in dolphinmainwindow.cpp:452-466
> This switch now exists twice in the same function. There must be a smarter way of doing that, right?
> I haven't looked at it in detail, but i hope you could see if this can be prevented.

That's 2 different switches. Look at `case QDialogButtonBox::No:` branch. I'm sure it's possible to merge them, but that would hurt readability.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham, markg
Cc: markg, ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/faf5fe5f/attachment.htm>