D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Mark Gaiser]

markg requested changes to this revision.
markg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinmainwindow.cpp:452-466
> +        switch (result) {
> +            case QDialogButtonBox::Yes:
> +                // Quit
> +                break;
> +            case QDialogButtonBox::No:
> +                if (!m_terminalPanel->isVisible())
> +                    actionCollection()->action("show_terminal_panel")->trigger();

This switch now exists twice in the same function. There must be a smarter way of doing that, right?
I haven't looked at it in detail, but i hope you could see if this can be prevented.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham, markg
Cc: markg, ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/bec0f3ef/attachment.htm>