D10968: Add an option to confirm trash emptying into settings

[Mark Gaiser]

markg accepted this revision.
markg added a comment.


  Looks fine, nice to have :)
  Feel free to ship it without updating the review for that one little pointer position change.
  
  Or you can update the diff and ship right after, your call.

INLINE COMMENTS

> confirmationssettingspage.h:48
>      QCheckBox* m_confirmMoveToTrash;
> +    QCheckBox *m_confirmEmptyTrash;
>      QCheckBox* m_confirmDelete;

Consistency. issue, nothing big.
QCheckbox* ....

REPOSITORY
  R318 Dolphin

BRANCH
  empty-trash-confirmation

REVISION DETAIL
  https://phabricator.kde.org/D10968

To: rominf, #dolphin, ngraham, markg
Cc: markg, ngraham, rkflx, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/bc097b20/attachment.htm>