D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Roman Inflianskas]

rominf marked an inline comment as done.
rominf added inline comments.

INLINE COMMENTS

> ngraham wrote in dolphinmainwindow.cpp:438
> Let's phrase this text in a more standard, grammatically correct manner:
> 
> "A program is still running in the Terminal panel. Are you sure you want to quit?"
> 
> Bonus points if we can get the actual running command and display it in the text here somehow. Also +1 for @rkflx's suggestion for a button that will show the terminal panel if it's hidden.

Done your task for bonus points and @rkflx's suggestion.

> ngraham wrote in dolphinmainwindow.cpp:444
> No word puzzles, please. Let's add the program within the `i18n` function call using a format string, rather than string concatenation.

Sorry, I didn't know that `i18n` works that way. Fixed it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham
Cc: ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180302/14243d11/attachment.htm>