D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

Nathaniel Graham noreply at phabricator.kde.org
Fri Mar 2 17:44:42 GMT 2018


ngraham added inline comments.

INLINE COMMENTS

> dolphinmainwindow.cpp:444
> +                m_terminalPanel->runningProgramName() +
> +                i18n("' is still running in the Terminal panel. Are you sure you want to quit?"),
> +                QStringList(),

No word puzzles, please. Let's add the program within the `i18n` function call using a format string, rather than string concatenation.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham
Cc: ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180302/990a2d85/attachment.htm>


More information about the kfm-devel mailing list