D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Nice patch! You're really feeding Dolphin rocket fuel today! One comment: see below.
  
  Also, while you're knocking out usability issues in Dolphin left and right, would you consider taking a look at https://bugs.kde.org/show_bug.cgi?id=154499?

INLINE COMMENTS

> dolphinmainwindow.cpp:438
> +                                                          QMessageBox::Warning,
> +                                                          i18n("You have a terminal panel running a program, are you sure you want to quit?"),
> +                                                          QStringList(),

Let's phrase this text in a more standard, grammatically correct manner:

"A program is still running in the Terminal panel. Are you sure you want to quit?"

Bonus points if we can get the actual running command and display it in the text here somehow. Also +1 for @rkflx's suggestion for a button that will show the terminal panel if it's hidden.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham
Cc: ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180302/453c3538/attachment.htm>