D10959: Add action for focusing Terminal Panel

[Roman Inflianskas]

rominf added a comment.


  In D10959#216883 <https://phabricator.kde.org/D10959#216883>, @rkflx wrote:
  
  > In D10959#216881 <https://phabricator.kde.org/D10959#216881>, @rominf wrote:
  >
  > > It moves focus to the previously activated widget.
  >
  >
  > Correct, but as URL bar and main viewport are a single widget, in most cases it will not do what I believe users will expect it should do. Normally you navigate in the main view, then open the terminal, then navigate some more. Focussing the URL bar in that case is not helpful. Perhaps when this widget gets focus, it should default to the main view and not the URL bar? You might want to look into that.
  >
  > > actually this variant was implemented in the previous commit
  >
  > Unless I missed something, your previous iteration had no unfocussing at all.
  
  
  OK. Agreed. I changed back to `m_activeViewContainer->setFocus(Qt::FocusReason::ShortcutFocusReason);`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10959

To: rominf, #dolphin
Cc: rkflx, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180302/2ae2d88d/attachment.htm>