D10959: Add action for focusing Terminal Panel

[Roman Inflianskas]

rominf added a comment.


  In D10959#216856 <https://phabricator.kde.org/D10959#216856>, @rkflx wrote:
  
  > Another idea would be to make [F4] open the Terminal if it was closed, and focus the Terminal if it was already open. This would be in line with standard behaviour for text-input widgets toggled by a keyboard shortcut (see also D10246#200226 <https://phabricator.kde.org/D10246#200226>). Kate already has this behaviour: Set [F4] for Focus Terminal, and you'll even have de-focus right there.
  >
  > The only caveat would be that closing the Terminal would have to be done differently (Kate also has this problem), but I guess Terminal users know about [Ctrl] + [D]? Or we could always show the Close button? Or the menu entry is enough?
  
  
  Nope. I'm against changing the behaviour of [F4]. There could be some running application opened in the panel (`watch ls` for example). That means that [Ctrl] + [D] is not longer an option. Showing the Close button is not an option too because it's inconsistent with other panels (I mean when the panels are locked).
  
  > My concern here is mainly that having an extra/different shortcut is not very intuitive or user-friendly. I'd suggest two steps:
  > 
  > - This Diff: Make Focus also open the Terminal.
  
  Done.
  
  > - This Diff: Make Focus also defocus the Terminal.
  
  Done.
  
  > - New Diff: Discuss re-assigning [F4] and how to handle the caveats.
  
  Declined. See above.
  
  > Also, the patch is broken: Triggering the shortcut without the Terminal panel open crashes Dolphin for me.
  
  Thank you. I fixed it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10959

To: rominf, #dolphin
Cc: rkflx, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180302/f61643f4/attachment.htm>