D10959: Add action for focusing Terminal Panel

[Henrik Fehlauer]

rkflx added subscribers: ngraham, rkflx.
rkflx added a comment.


  Another idea would be to make [F4] open the Terminal if it was closed, and focus the Terminal if it was already open. This would be in line with standard behaviour for text-input widgets toggled by a keyboard shortcut (see also D10246#200226 <https://phabricator.kde.org/D10246#200226>). Kate already has this behaviour: Set [F4] for Focus Terminal, and you'll even have de-focus right there.
  
  The only caveat would be that closing the Terminal would have to be done differently (Kate also has this problem), but I guess Terminal users know about [Ctrl] + [D]? Or we could always show the Close button? Or the menu entry is enough?
  
  My concern here is mainly that having an extra/different shortcut is not very intuitive or user-friendly. I'd suggest two steps:
  
  - This Diff: Make Focus also open the Terminal.
  - This Diff: Make Focus also defocus the Terminal.
  - New Diff: Discuss re-assigning [F4] and how to handle the caveats.
  
  @ngraham Thoughts?
  
  ---
  
  Also, the patch is broken: Triggering the shortcut without the Terminal panel open crashes Dolphin for me.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10959

To: rominf, #dolphin
Cc: rkflx, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180302/c8ef7972/attachment.htm>