D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Kai Uwe Broulik]

broulik added a comment.


  Good idea! When I just close the Terminal panel (press F4 <https://phabricator.kde.org/F4>) the console keeps running, right?

INLINE COMMENTS

> dolphinmainwindow.cpp:425
> +        // QDialogButtonBox::Cancel -> do nothing
> +        QDialog *dialog = new QDialog(this, Qt::Dialog);
> +        dialog->setWindowTitle(i18nc("@title:window", "Confirmation"));

Can't you use any of `KMessageBox`'s built-in dialogs rather than creating the entire `QDialog` yourself?

> dolphinmainwindow.cpp:440
> +                                                          QStringList(),
> +                                                          i18n("Do not ask again"),
> +                                                          &doNotAskAgainCheckboxResult,

This is the name of the key that will be stored in settings to remember this. The text in the user interface is always "Do not ask again"

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin
Cc: broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180302/50a9e28b/attachment.htm>