D10804: Show "Empty Trash" button inside trash directory
Roman Inflianskas
noreply at phabricator.kde.org
Fri Mar 2 05:22:07 GMT 2018
rominf added a comment.
In D10804#216484 <https://phabricator.kde.org/D10804#216484>, @markg wrote:
> Is the singleton class really needed? It imho seems a bit overkill for merely the trash status.
> On the other hand, it does neatly move some trash functionality in it's own little space. But a class?..
> The functions are also all self contained so it might be better suited in it's own namespace (say a TrashHelper::<youFunctions>).
Yep, a singleton is needed, though I don't like it too. I have a signal to emit. That means I have to have `QObject`. Nobody can emit signals from static functions, hence I need a singleton.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D10804
To: rominf, #dolphin, #kde_applications, ngraham, rkflx, markg
Cc: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180302/7c149c1d/attachment.htm>
More information about the kfm-devel
mailing list