D13806: Store icons with correct devicePixelRatio

Nathaniel Graham noreply at phabricator.kde.org
Sat Jun 30 14:50:07 BST 2018


ngraham added reviewers: cfeck, broulik.
ngraham added a comment.


  Thanks for the patch! Conceptually, this makes sense to me. Can you attach some before-and-after screenshots showing the impact of the change?
  
  Does this fix any Bugzilla tickets?

INLINE COMMENTS

> kfileitemmodelrolesupdater.cpp:555
>  
> +    scaledPixmap.setDevicePixelRatio(qApp->devicePixelRatio());
>      data.insert("iconPixmap", scaledPixmap);

Should this also use `devicePixelRatioF()`?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13806

To: abrahams, #dolphin, cfeck, broulik
Cc: ngraham, kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180630/573cd2d7/attachment.htm>


More information about the kfm-devel mailing list