D13768: Modernize View Properties window

Nathaniel Graham noreply at phabricator.kde.org
Wed Jun 27 21:00:41 BST 2018


ngraham created this revision.
ngraham added reviewers: Dolphin, elvisangelaccio, broulik.
ngraham requested review of this revision.

REVISION SUMMARY
  Like D12571 <https://phabricator.kde.org/D12571>, but for the View Properties Window. This allows us to use a `QFormLayout` as the top-level layout and simplify the code a lot, including no longer using the now-unnecessary paradigm of putting a layout inside a `QWidget`.

TEST PLAN
  Window still resizes properly when the Additional Information content is shown or hidden.
  
  Global view properties, additional information hidden:
  
  Global view properties, additional information shown:
  
  Per-folder view properties, additional information hidden:
  
  Per-folder view properties, additional information shown:

BRANCH
  modernize-view-properties-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13768

AFFECTED FILES
  src/settings/viewpropertiesdialog.cpp

To: ngraham, #dolphin, elvisangelaccio, broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180627/bd576135/attachment.htm>


More information about the kfm-devel mailing list