D13749: Port from KComboBox to QComboBox

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Jun 27 10:27:25 BST 2018


broulik added inline comments.

INLINE COMMENTS

> dolphinfontrequester.h:23
>  
> +#include <QComboBox>
>  #include <QFont>

Not needed since you forward-declare it below and only use a pointer to it

> viewsettingstab.h:25
>  
> +#include <QComboBox>
>  #include <QWidget>

Not needed

> viewpropertiesdialog.h:26
>  
> +#include <QComboBox>
>  #include <QDialog>

Not needed

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13749

To: ngraham, #dolphin, elvisangelaccio
Cc: broulik, kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180627/ea1eff7b/attachment.htm>


More information about the kfm-devel mailing list