D12571: Modernize Settings window

[Nathaniel Graham]

ngraham added a comment.


  In D12571#282938 <https://phabricator.kde.org/D12571#282938>, @cfeck wrote:
  
  > You only need KComboBox if you use the KCompletion features.
  
  
  Yeah, and we're not using them here.
  
  > Could we have a consistent "Type *var" vs. "Type* var" style? I prefer the former, but I haven't checked what Dolphin maintainers prefer.
  
  Good point. "Type *var" seems to be more common in Dolphin's codebase, so I'll use that.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12571

To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: cfeck, medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180626/240d79ad/attachment.htm>