D12571: Modernize Settings window

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D12571#278266 <https://phabricator.kde.org/D12571#278266>, @ngraham wrote:
  
  > In D12571#277946 <https://phabricator.kde.org/D12571#277946>, @elvisangelaccio wrote:
  >
  > > In D12571#276764 <https://phabricator.kde.org/D12571#276764>, @ngraham wrote:>
  > >
  > > > Don't they control how the view appears on startup?
  > >
  > >
  > > Only "Split view mode" does. The other ones control things that are outside the view. How about using "On startup:" and rewording the sentences on the checkboxes where necessary?
  >
  >
  > I was using the term "View" from a user perspective. I think to people who aren't Dolphin developers, these are view settings. The technical distinction between the view, its container, and the main window are not relevant to users, or important to understand.
  
  
  I disagree, but that's not the point anyway. Using "view" here would be just wrong. Why not using "window" instead?
  
  > 
  > 
  >> Other comments on the UI before looking at the code:
  >> 
  >> - In the Startup page, what does "Location" refer to? The groupbox made it clear it was the Home folder, now we are hiding this information.
  > 
  > "Home folder" has an established meaning: it's your user's own home folder. Using the label "Home folder" always seemed to imply that you could change your home folder, which was not true. In fact, this setting simply controls what folder dolphin shows on startup. The fact that you're on the "Startup" tab I think does a good job of suggesting that the settings on this page control Dolphin's behavior and appearance when it launches. Maybe I could add a small label at the top of the window explaining that?
  
  Fair enough. How about "Start in:" ?
  
  >> - The Confirmation tab now is better but still confusing. I don't see why we need to touch it at all honestly, given that there are only checkboxes in there.
  > 
  > I feel like there's resistance to the visual design conception itself. I'm getting the feeling that you simply don't like the labels-on-the-left paradigm itself. Perhaps we should address that rather than arguing over individual examples of its application.
  
  
  
  In D12571#278752 <https://phabricator.kde.org/D12571#278752>, @abetts wrote:
  
  > Guys, this work has been going on for a long time on something rather simple in aligning the settings design to what Plasma is doing. There should not be this much resistance to the change. Can we please move forward with the approval?
  
  
  Honestly I'm quite disappointed to read this.
  
  I can assure you there is no resistance to the visual design change from me.
  Is it true that I don't particularly like it and I'm sad that my feedback was ignored, but if that's what the VDG wants, so be it.
  
  But this patch currently has still issues (in particular, the Confirmations tab) and will be approved only when it's ready.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12571

To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180616/51d5f6b8/attachment.htm>