D13569: Use collapsible box to configure visible roles

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added reviewers: Dolphin, VDG.
Restricted Application added a project: Dolphin.
Restricted Application added a subscriber: kfm-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  A modal dialog that opens another modal dialog is bad UX and should be
  avoided whenever possible. These days we have `KCollapsibleGroupBox`
  that can be used to show advanced settings without cluttering the
  default layout.
  
  This change removes the `AdditionalInfoDialog` and uses a collapsible
  groupbox instead. The `Apply` buttons gets enabled whenever a role gets
  checked or unchecked, consistently with the existing checkboxes.

TEST PLAN
  Change visible roles in the view properties dialog.

REPOSITORY
  R318 Dolphin

BRANCH
  collapsible-view-props (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13569

AFFECTED FILES
  src/CMakeLists.txt
  src/settings/additionalinfodialog.cpp
  src/settings/additionalinfodialog.h
  src/settings/viewpropertiesdialog.cpp
  src/settings/viewpropertiesdialog.h

To: elvisangelaccio, #dolphin, #vdg
Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180616/855a61bd/attachment.htm>