D13349: [KBalooRolesProvider] Support properties of type QStringList

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Jun 5 09:16:20 BST 2018


broulik created this revision.
broulik added reviewers: Dolphin, elvisangelaccio.
Restricted Application added a project: Dolphin.
Restricted Application added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `QVariant::toString()` unwraps a `QStringList` with a single string to a `QString`, however a list with multiple entries returns a null string.
  Explicitly check for `KFileMetaData` property type and convert accordingly.
  
  BUG: 395033
  FIXED-IN: 18.04.3

TEST PLAN
  - Had an mp3 file with multiple artists, shows correctly in table view
  - Single artist also still shows fine
  
  (The surrounding tags code also uses hardcoded non-i18n `", "` so this is consistent with the rest)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13349

AFFECTED FILES
  src/kitemviews/private/kbaloorolesprovider.cpp

To: broulik, #dolphin, elvisangelaccio
Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180605/09e17571/attachment.htm>


More information about the kfm-devel mailing list