D13304: Fix scrolling to renamed file when using the rename dialog

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added reviewers: Dolphin, emateli.
Restricted Application added a project: Dolphin.
Restricted Application added a subscriber: kfm-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  The `RenameDialog::slotResult()` slot is currently never called because
  the dialog is deleted first, due to the usage of the `WA_DeleteOnClose`
  attribute. This breaks the scroll-to-renamed-file feature when the
  inline renaming is disabled.
  
  Instead of deleting the dialog on close, we can use `deleteLater()` when
  we are sure the dialog has actually finished its job, which is when the
  KIO move job emits the `result` signal.

TEST PLAN
  - Disable inline renaming
  - Rename a file so that it goes out of the view
  - Check whether the view scrolls to the renamed file.

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13304

AFFECTED FILES
  src/panels/folders/folderspanel.cpp
  src/views/dolphinview.cpp
  src/views/renamedialog.cpp

To: elvisangelaccio, #dolphin, emateli
Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180603/6d229f79/attachment.htm>