D14443: Use nullptr

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Jul 30 09:34:54 BST 2018


broulik added inline comments.

INLINE COMMENTS

> kitemlistview.cpp:308
>      delete m_widgetCreator;
> +    m_widgetCreator = nullptr;
>      m_widgetCreator = widgetCreator;

You're re-assigning it to something else immediately after

> kitemlistview.cpp:323
>      delete m_groupHeaderCreator;
> +    m_groupHeaderCreator = nullptr;
>      m_groupHeaderCreator = groupHeaderCreator;

Same

> kitemlistview.cpp:2744
>  }
> -

Unrelated whitespace change

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14443

To: al1xz, #dolphin
Cc: broulik, hallas, markg, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180730/0409fca4/attachment.htm>


More information about the kfm-devel mailing list