D14378: Remove custom icon selection for trash

[Pino Toscano]

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  Please, please, please:
  
  - again, no rush with changes
  - read again your own changes, because it looks like there is even no review by the own patch author
  - **TEST** your changes

INLINE COMMENTS

> placesitemeditdialog.cpp:62
>  {
> -    return m_iconButton->icon();
> +    return m_iconButton ? m_iconButton->icon() : QString();
>  }

And actually this must return `m_icon` in case `m_iconButton` is null, to look like there was no icon change.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14378

To: shubham, ngraham, #dolphin, broulik, pino, elvisangelaccio
Cc: elvisangelaccio, pino, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180728/b45a67c3/attachment.htm>