D14378: Remove custom icon selection for trash

[Pino Toscano]

pino requested changes to this revision.
pino added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> placesitemeditdialog.cpp:67-71
> +    if (isIconEditable()) {
> +        return m_iconButton->icon();
> +    } else {
> +        return QString();
> +    }

This is slightly overkill:

  return m_iconButton ? m_iconButton->icon() : QString();

is more than enough.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14378

To: shubham, ngraham, #dolphin, broulik, pino, elvisangelaccio
Cc: elvisangelaccio, pino, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180728/f4da714d/attachment.htm>