D14378: Remove custom icon selection for trash

[Pino Toscano]

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  It is a good start, but not enough:
  
  - `PlacesItemEditDialog::icon()` will crash now, so its usage of m_iconButton must be guarded

INLINE COMMENTS

> placesitemeditdialog.cpp:147
> +    
> +    // Draw the icon button for the entry only if it's *NOT* TRASH
> +    if (m_url.scheme() != QLatin1String("trash")) {

No need to SCREAM in comments :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14378

To: shubham, ngraham, #dolphin, broulik, pino
Cc: pino, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180726/5e5695d6/attachment.htm>