D14378: Remove custom icon selection for trash

Nathaniel Graham noreply at phabricator.kde.org
Wed Jul 25 20:24:20 BST 2018


ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This works fine for me, and I think the code is sensible. It's quite a mess to not set `m_iconButton` at all in this case, so I'm okay with  the patch as-is.
  
  Let's wait for a final opinion from another #dolphin <https://phabricator.kde.org/tag/dolphin/> person.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14378

To: shubham, ngraham, #dolphin, broulik
Cc: pino, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180725/ffba3f5a/attachment.htm>


More information about the kfm-devel mailing list