D14378: Remove custom icon selection for trash

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> ngraham wrote in placesitemeditdialog.cpp:149
> Let's do this a little differently to conform to KDE style guidelines:
> 
>   if (m_url.scheme() == QLatin1String("trash")) {
>       formLayout->addRow(i18nc("@label", "Choose an icon:"), m_iconButton);
>   } else {
>       m_iconButton->setVisible(false);
>   }

Or even better, not create the KIconButton at all, in that case -- note you will need to check all the usages of `m_iconButton`.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14378

To: shubham, ngraham, #dolphin, broulik
Cc: pino, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180725/434613ef/attachment.htm>