D14378: Remove custom icon selection for trash

[Nathaniel Graham]

ngraham added a reviewer: broulik.
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> placesitemeditdialog.cpp:149
> +    m_iconButton->setVisible(m_url.scheme() != QLatin1String("trash"));
> +    if(!(m_url.scheme() == QLatin1String("trash")))
>      formLayout->addRow(i18nc("@label", "Choose an icon:"), m_iconButton);

Let's do this a little differently to conform to KDE style guidelines:

  if (m_url.scheme() == QLatin1String("trash")) {
      formLayout->addRow(i18nc("@label", "Choose an icon:"), m_iconButton);
  } else {
      m_iconButton->setVisible(false);
  }

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14378

To: shubham, ngraham, #dolphin, broulik
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180725/b870283f/attachment.htm>