D14199: Simplify the context menu handling functions in FoldersPanel

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Jul 18 13:34:49 BST 2018


broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  I got completely confused by the code, `TreeViewContextMenu` internally creates a `QMenu` and then does `exec()` in that confusingly named `open()` method. I assumed `TreeViewContextMenu` *was* the menu.
  
  Looking good, thanks!
  Do you have commit access?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14199

To: hallas, broulik
Cc: broulik, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180718/0c1e7b52/attachment.htm>


More information about the kfm-devel mailing list