D12571: Modernize Settings window

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> behaviorsettingspage.cpp:24
>  #include "views/viewproperties.h"
> +#include "global.h"
>  

Please put it before viewproperties.h (again, to preserver sorting of includes)

> ngraham wrote in startupsettingspage.cpp:52
> My understanding of Qt's layout system is that any item (including a layout) that will be added to a layout doesn't need to be given a parent, since Qt automatically re-parents it to the layout it's added to.
> 
> https://doc.qt.io/qt-5/layout.html#tips-for-using-layouts

Oh, right!

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12571

To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: fabianr, cfeck, medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180704/6fcfd444/attachment.htm>