D12571: Modernize Settings window

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> fabianr wrote in behaviorsettingspage.cpp:77
> Yes, 18 comes from the HIG. That's the "default px representation" for plasmas and kirigamis gridUnit.

@elvisangelaccio

I've added this to a Dolphin-wide global for now, but it seems like it might make more sense to put it in an even more global location. Maybe in `KXMLGui`? Or somewhere else? I can submit a patch for it if you think that makes sense.

> elvisangelaccio wrote in startupsettingspage.cpp:52
> Please add a parent to this layout

My understanding of Qt's layout system is that any item (including a layout) that will be added to a layout doesn't need to be given a parent, since Qt automatically re-parents it to the layout it's added to.

https://doc.qt.io/qt-5/layout.html#tips-for-using-layouts

> elvisangelaccio wrote in startupsettingspage.cpp:69
> Please add a parent to this layout

Same ^^

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12571

To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: fabianr, cfeck, medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180703/a7f9dc6e/attachment.htm>