D12571: Modernize Settings window

[Fabian Riethmayer]

fabianr added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in behaviorsettingspage.cpp:77
> Please add a global variable instead of hardcoding 18 in different places.
> 
> /OT
> Does this 18 come from some HIG? If yes, it would be a good idea to put it in some global config that can be shared across all KDE apps.
> So that if one day we realize 18 is not good anymore and we want to use 19, we will have just one thing to update.

Yes, 18 comes from the HIG. That's the "default px representation" for plasmas and kirigamis gridUnit.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12571

To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: fabianr, cfeck, medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180703/605bae85/attachment.htm>