D13814: Speedup sort

[Stefan Brüns]

bruns added a comment.


  In D13814#285736 <https://phabricator.kde.org/D13814#285736>, @jtamate wrote:
  
  > In D13814#285691 <https://phabricator.kde.org/D13814#285691>, @bruns wrote:
  >
  > > I assume you are sorting by name with "natural sorting". There may be another possibility for speedup here:
  > >  `QCollator::sortkey()`,  http://doc.qt.io/qt-5/qcollator.html#sortKey
  > >
  > > It might be possible to generate the sortkey in e.g. https://phabricator.kde.org/source/dolphin/browse/master/src/kitemviews/kfileitemmodel.cpp$1334
  >
  >
  > Unfortunately is not a trivial change, because it uses a <QByteArray, QVariant> and  QCollatorSortKey can not be transformed into a QVariant, therefore it will not be in in this patch.
  
  
  You can store any type in QVariant, see http://doc.qt.io/qt-5/qmetatype.html#Q_DECLARE_METATYPE
  
  But the comment was meant as a hint where to look for performance improvements, not specifically for this review.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: apol, bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180702/65eee9e0/attachment.htm>