D13814: Speedup sort

[Jaime Torres Amate]

jtamate added a comment.


  In D13814#285686 <https://phabricator.kde.org/D13814#285686>, @bruns wrote:
  
  > In D13814#285660 <https://phabricator.kde.org/D13814#285660>, @markg wrote:
  >
  > > > I don't know if that's still an issue or if your patch re-introduces whatever the problem was (race conditions?). You could look back in the commit log when that was added to figure out more about it.
  > >
  > > To answer that myself, it was done in this commit: https://cgit.kde.org/dolphin.git/commit/src/kitemviews/kfileitemmodel.cpp?id=d9680ead8099df9a2b06bfed61a62923778996f2
  > >  And doesn't explain anything :)
  >
  >
  > If you follow the link in the comment, i.e. https://bugs.kde.org/show_bug.cgi?id=312679, it mentions date sorting and KDateTime being non-reentrant.
  
  
  Yes, that is why parallelMergeSort is only used to sort by name. All methods of QCollator are reentrant (http://doc.qt.io/qt-5/qcollator.html)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180701/b2a1dfe1/attachment.htm>