D7700: Show list of tags in PlacesView

Henrik Fehlauer noreply at phabricator.kde.org
Wed Jan 31 14:06:41 GMT 2018


rkflx added a comment.


  In https://phabricator.kde.org/D7700#198384, @michaelh wrote:
  
  > I could not try this one. `arc patch D7700` failed against master and Applications/17.12.
  
  
  Try against `Applications/17.08` or any commit close to the upload date. Nevertheless, @nicolasfella should rebase this patch on current `master` eventually.
  
  > This looks like a raw diff. If so, please consider using `arc`.
  
  Phab shows a popup if you point your mouse over the date/time  entry of a comment indicating a patch upload or update. Here we see "Via Web", but obviously `arc` would be more friendly for reviewers because of the included base revision.
  
  ---
  
  Regarding the topic: I did not read everything in detail, but please make sure not to break Gwenview and other users of `KFilePlaces` again, I'm still busy with the fallout from the last breakage… Also, performance matters, so ensure (and measure!) we won't regress for Dolphin's default config.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7700

To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham
Cc: rkflx, mmustac, spoorun, michaelh, renatoo, anthonyfieroni, cfeck, elvisangelaccio, emmanuelp, ngraham, alexeymin, #dolphin, navarromorales, isidorov, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180131/00b25c6f/attachment.htm>


More information about the kfm-devel mailing list