D10190: Fix resetting "View Modes" preferences to defaults

Robert Hoffmann noreply at phabricator.kde.org
Wed Jan 31 10:10:20 GMT 2018


hoffmannrobert marked an inline comment as done.
hoffmannrobert added a comment.


  I changed the title of this revision. Is this sufficient or is a new commit needed?

INLINE COMMENTS

> elvisangelaccio wrote in viewsettingstab.cpp:236
> This was added to fix https://bugs.kde.org/show_bug.cgi?id=292698
> 
> Can you please check that this patch does not reintroduce that bug?

I checked https://bugs.kde.org/show_bug.cgi?id=292698 , tried out to reproduce the described behaviour using scenarios from description and comment 2: https://bugs.kde.org/show_bug.cgi?id=292698#c2

Icons stay at the expected size set in the status bar when changing font width in the settings. Icons don't change sizes unexpectedly.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10190

To: hoffmannrobert
Cc: ltoscano, ngraham, elvisangelaccio, michaelh, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180131/20fac3ab/attachment.htm>


More information about the kfm-devel mailing list