D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only

[Michael Heidelbach]

michaelh added a comment.


  Both test for empty failed because the spy timed out!
  IMO they should not, because consumers rely on the `metaDataRequestFinished` signal.
  Please tell me if you disagree.
  
  I don't know why they fail, yet. Because line 371 is reached in src/filemetadataprovider.cpp <https://phabricator.kde.org/D10113#change-moyZ89ZQ9veK>.
  
    370    if (items.isEmpty()) {
    371	​        emit loadingFinished();
  
  Maybe it is best to leave early in `filemetadatawidget.cpp:234`

REPOSITORY
  R824 Baloo Widgets

BRANCH
  unittest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10119

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180130/420386db/attachment.htm>