D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> michaelh wrote in filemetadataprovider.cpp:323
> In that case it might be safer to do
> 
>          IndexedDataRetriever *ret = new IndexedDataRetriever(filePath, this);
>   	​connect(ret, SIGNAL(finished(KJob*)), this, SLOT(slotLoadingFinished(KJob*)));       
>          
>           insertBasicData();
>   	​insertEditableData();
>   	​emit dataAvailable();
>   
>   ​        ret->start();
> 
> Because once loadingFinished() is signalled it's over. dataAvailable(); won't get processed anymore.

Sounds good, but please explain why we are moving this signal in the commit message. This will make easier to `git blame` this code in the future.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180129/fa638833/attachment.htm>