D10113: baloo-widgets: Emit metaDataRequestFinished once per request

Elvis Angelaccio noreply at phabricator.kde.org
Sat Jan 27 17:33:48 GMT 2018


elvisangelaccio added a comment.


  +1, looks good to me.

INLINE COMMENTS

> michaelh wrote in filemetadataprovider.cpp:323
> Is it guaranteed, that this is emitted before IndexedDataRetriever job is finished?

I don't think so, because `IndexedDataRetriever::start()` does not block.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180127/f10ad073/attachment.htm>


More information about the kfm-devel mailing list