D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only
Michael Heidelbach
noreply at phabricator.kde.org
Sat Jan 27 09:18:51 GMT 2018
michaelh added inline comments.
INLINE COMMENTS
> CMakeLists.txt:17
> + Qt5::Test Qt5::Widgets
> +)
This certainly needs some cleanup. I just added more and more libs until it compiled. If there is a better strategy than trial-and-error. Let me know please.
> filemetadatawidgettest.cpp:69
> + QEXPECT_FAIL("", "Wait for consecutive signals timed out", Continue);
> + QVERIFY(spy.wait(1000));
> +}
Not sure if this really needed. The original code already fails at line 64.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10119
To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180127/e3eee30c/attachment.htm>
More information about the kfm-devel
mailing list