D9333: Make sure that old URLs do not appear duplicated in places model

Elvis Angelaccio noreply at phabricator.kde.org
Tue Jan 23 21:53:12 GMT 2018


elvisangelaccio accepted this revision.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> placesitemmodel.cpp:58
>      // added, which is only read by PlacesItemModel.
> -    const char AppNamePrefix[] = "-places-panel";
> -
> +    const QString AppNamePrefix = QStringLiteral("-places-panel");
>      static QList<QUrl> balooURLs = {

One last nitpick: this is actually a suffix, so while at it I'd rename it `AppNameSuffix`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9333

To: renatoo, mwolff, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, broulik, ervin, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180123/54d5d90c/attachment.htm>


More information about the kfm-devel mailing list