D9711: Fix renamed file reclaims focus

[Andreas Krutzler]

akrutzler added a comment.


  In https://phabricator.kde.org/D9711#193793, @elvisangelaccio wrote:
  
  > I had a look and this bug is caused by the `forceUrlsSelection()` call in `slotRoleEditingFinished()` (added by https://phabricator.kde.org/R318:478f404b8abf924a0e3e21bbf1dd49aefbe47672).
  >  The problem is that we are marking the item being renamed as the `m_currentItemUrl`, but that is not necessarily correct as this bug shows.
  >
  > @emateli is right that `forceUrlsSelection()` is a better place to put this check in. Adding
  >
  >   if (m_container->controller()->selectionManager()->hasSelection()) {
  >       return;
  >   }
  >
  >
  > at the beginning of the method fixes the bug for me.
  
  
  With that,  https://phabricator.kde.org/D6312 doesn't work anymore. Because when calling `forceUrlsSelection()` in `slotRoleEditingFinished()`, there is always a selection.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9711

To: akrutzler, ngraham, michaelh, #dolphin, elvisangelaccio
Cc: emateli, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180121/6a6ca4f1/attachment.htm>