D10006: Build TerminalPanel also on Windows

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added reviewers: Dolphin, Craft.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  terminalpanel.cpp *should* compile on Windows, so there is no reason to
  remove it from the build and use tons of #ifdefs in dolphinmainwindow.
  
  We still keep the terminal panel disabled on Windows
  (i.e. the two remaining #ifndef Q_OS_WIN in dolphinmainwindow),
  because it is probably not functional.
  
  But at least we won't break the Windows CI every time
  someone touches the terminal panel code (see e.g. https://phabricator.kde.org/R318:2e942237c977fc3fd7d3712167d859a8f56371e9).

TEST PLAN
  Builds on Linux, someone on Windows should test this patch if possible.

REPOSITORY
  R318 Dolphin

BRANCH
  fix-terminalpanel-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10006

AFFECTED FILES
  src/CMakeLists.txt
  src/dolphinmainwindow.cpp
  src/dolphinmainwindow.h

To: elvisangelaccio, #dolphin, #craft
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180121/9358663c/attachment.htm>