D9836: Use BatchRenameJob to rename multiple files in Dolphin

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Looks good, but please bump the minimum KF5 version in CMakeLists.txt to 5.42

INLINE COMMENTS

> renamedialog.cpp:201
>  {
> -    m_lineEdit->setFocus();
> -
> -    QDialog::showEvent(event);
> +    Q_UNUSED(oldUrl);
> +    m_renamedItems << newUrl;

Nitpick, semicolon not necessary.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9836

To: chinmoyr, #dolphin, elvisangelaccio
Cc: elvisangelaccio, ngraham, broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180121/31656e7d/attachment.htm>