D9985: Fix place item edit after creation

Elvis Angelaccio noreply at phabricator.kde.org
Sat Jan 20 17:25:34 GMT 2018


elvisangelaccio added inline comments.

INLINE COMMENTS

> placesitem.cpp:132
>  {
> -    if (bookmark == m_bookmark) {
> -        return;
> -    }
> +    const bool bookmarkDataChanged = !(bookmark == m_bookmark);
>  

Why not `bookmark != m_bookmark` ?

> placesitem.cpp:134
>  
> +    // bookmark object must be update to keep in sync with source model
>      m_bookmark = bookmark;

Typo: "must be updated"

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9985

To: renatoo, #dolphin, ngraham
Cc: elvisangelaccio, lbeltrame, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180120/7102b1cf/attachment.htm>


More information about the kfm-devel mailing list