D9333: Make sure that old URLs do not appear duplicated in places model

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> placesitemmodel.cpp:56
>  namespace {
>      // Hence a prefix to the application-name of the stored bookmarks is
>      // added, which is only read by PlacesItemModel.

Please fix this comment, it's a leftover of https://phabricator.kde.org/R318:da6f8fe0862585287153f0d90e19eab0b34bfbef but now it doesn't make sense to start the sentence with "Hence".

While at it, let's make `AppNamePrefix` a QStringLiteral ?

> placesitemmodel.cpp:174
> +        if (m_hiddenItemsShown || !m_sourceModel->isHidden(sourceIndex)) {
> +            pos ++;
>          }

please remove the space before the ++

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9333

To: renatoo, mwolff, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, broulik, ervin, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180120/49181639/attachment.htm>