Review Request 116118: Set the focus to the active view, after leaving the terminal panel.

[Adrian Chaves]

> On Feb. 27, 2014, 2:14 p.m., Frank Reininghaus wrote:
> > Thanks for looking into this.
> > 
> > What happens if the user switches to another virtual desktop and then back to the one showing the Dolphin window? If the view is focused also in that case, then this is probably not what the user wants.
> 
> Emmanuel Pescosta wrote:
>     Focus is still in the terminal panel.
> 
> Emmanuel Pescosta wrote:
>     Btw. the places panel uses the same signal to enable/disable the places selector of the url navigator.
>     
>     So I think it should not introduce any bugs, related to activity/virtual desktop/... switching. ;)
> 
> Frank Reininghaus wrote:
>     Here it's not, the view gets the focus.
> 
> Frank Reininghaus wrote:
>     About the Places Panel: there is a bug which is related to this signal and the URL navigator: https://bugs.kde.org/show_bug.cgi?id=304551 (and you can also see the mentioned 'jumping' when swiching desktops). I think that it should better be fixed in the URL navigator though.
> 
> Emmanuel Pescosta wrote:
>     Hmm strange.
>     
>     I open the terminal (F4), then write some letters to test if the terminal has the focus, then switch to the second virtual desktop, 
>     do some things there, then switch back to the previous virtual desktop, click on Dolphins title bar -> the terminal still has the focus.
>     
>     Also activity switching works for me.
> 
> Adrian Chaves wrote:
>     I've just tested the patch (after a minor change to the connect call) and I can confirm the issue reported by Frank. I write on the Dolphin terminal, switch to a different virtual desktop, switch back, and the focus is no longer on the terminal but on the main view.

I’ve just submitted a patch on Phabricator which forks this patch and fixes the issue with virtual desktop changes: https://phabricator.kde.org/D9955


- Adrian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116118/#review51052
-----------------------------------------------------------


On Feb. 27, 2014, 2:05 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116118/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 2:05 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 298467
>     http://bugs.kde.org/show_bug.cgi?id=298467
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Set the focus to the active view, after leaving the terminal panel.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h cb97612 
>   dolphin/src/dolphinmainwindow.cpp 8473014 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/116118/diff/1/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180117/f9e263cf/attachment.htm>