D9662: folderspanel context-menu option "Limit to Home Directory" should be always visible

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I'm late to the party, but oh well.

INLINE COMMENTS

> folderspanel.cpp:330
> +        baseUrl = url;
> +        baseUrl.setPath(QString('/'));
> +    } else if (Dolphin::homeUrl().isParentOf(url) || (Dolphin::homeUrl() == url)) {

While at it, use `QStringLiteral()`

> folderspanel.cpp:352
>      const int index = m_model->index(url);
> -    if (index >= 0) {
> +    if (jumpHome == true) {
> +      emit folderActivated(baseUrl);

`if (jump)` is enough, no need to compare with `true`.

> folderspanel.h:94
>       */
> -    void loadTree(const QUrl& url);
> +    void loadTree(const QUrl& url, bool allowJumpHome = false);
>  

Bools in APIs are bad for readability, better use enums (e.g. `loadUrl(url, FoldersPanel::AllowJumpHome)`).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9662

To: michaelh, #dolphin, emmanuelp, ngraham
Cc: elvisangelaccio, michaelh, spoorun, navarromorales, isidorov, firef, ngraham, andrebarros, alexeymin, genaxxx, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180114/73cf4657/attachment.htm>